[PATCH] D65261: [PowerPC] Fix ICE when truncating to vector with odd-size elements.

Chaofan Qiu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 9 00:14:24 PDT 2019


qiucf marked an inline comment as done.
qiucf added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/pr25080.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-- -mcpu=pwr8 < %s | FileCheck %s --check-prefix=LE
----------------
MaskRay wrote:
> Is update_llc_test_checks too much for an assertion fix?
Checking if it exits successfully with no diagnostics is enough for an assertion fix. Here I just disabled doing the optimization since the occasion is rare.

In case someone would like to do it for such odd vectors in the future, I recommend to keep it as-is. After that, this case can notify and be changed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65261/new/

https://reviews.llvm.org/D65261





More information about the llvm-commits mailing list