[PATCH] D65848: [ThinLTO][AutoFDO] Fix memory corruption due to race condition from thin backends

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

Thanks for the change.



================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:383
   void findInlinedFunctions(DenseSet<GlobalValue::GUID> &S, const Module *M,
+                            DenseMap<uint64_t, StringRef> &GUIDToFuncNameMap,
                             uint64_t Threshold) const {
----------------
If we can avoid adding the param, that will be great. GUIDToFuncNameMap is only used when the format is compact. When the interface of findInlinedFunctions is used, I hope the user doesn't have to worry about how to create a GUIDToFuncNameMap. That is why I think we may pass the handle of GUIDToFuncNameMap to FunctionSamples objects in GUIDToFuncNameMapper constructor. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65848/new/

https://reviews.llvm.org/D65848