[PATCH] D65352: [CodeGen] Require a name for a block addr target

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 11:50:31 PDT 2019


nickdesaulniers added inline comments.


================
Comment at: test/CodeGen/X86/callbr-asm-obj-file.ll:1
+; RUN: llc < %s -mtriple=x86_64-linux-gnu -filetype=obj -o - \
+; RUN:  | llvm-objdump -triple x86_64-linux-gnu -d - \
----------------
nathanchance wrote:
> nickdesaulniers wrote:
> > When I run this test case locally, I get:
> > 
> > ```
> > $ llc < callbr-asm-obj-file.ll -filetype=obj -mtriple=x86_64-linux-gnu
> > <unknown>:0: error: Undefined temporary symbol
> > ```
> > 
> > Am I holding it wrong?
> Do you have D65304 as well? With just this patch, I see that same error but with both patches, this test case works as expected.
> 
> 
Ah, I missed the parent revision relationship between the two patches.  Does phabricator UI show this relation anywhere?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65352/new/

https://reviews.llvm.org/D65352





More information about the llvm-commits mailing list