[PATCH] D65922: [lld][WebAssembly] Allow linking of PIC code into static binaries

Alon Zakai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 11:02:03 PDT 2019


kripken resigned from this revision.
kripken added a subscriber: tlively.
kripken added a comment.

Nothing looks wrong to me here, but I don't know enough to fully understand it, sorry - like what the various indexes are, what a virtual address means here, etc.

Perhaps @tlively can take a look if we need a second reviewer, as he's worked on this code recently?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65922/new/

https://reviews.llvm.org/D65922





More information about the llvm-commits mailing list