[PATCH] D65960: Fix environment variable passing in libc++'s `SSHExecutor` `lit` utility

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 10:33:34 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL368317: [libc++] Fix environment variable passing in libc++'s `SSHExecutor` `lit`… (authored by ldionne, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D65960?vs=214179&id=214184#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65960/new/

https://reviews.llvm.org/D65960

Files:
  libcxx/trunk/utils/libcxx/test/executor.py


Index: libcxx/trunk/utils/libcxx/test/executor.py
===================================================================
--- libcxx/trunk/utils/libcxx/test/executor.py
+++ libcxx/trunk/utils/libcxx/test/executor.py
@@ -187,7 +187,7 @@
         remote = self.user_prefix + self.host
         ssh_cmd = [self.ssh_command, '-oBatchMode=yes', remote]
         if env:
-            env_cmd = ['env'] + ['%s=%s' % (k, v) for k, v in env.items()]
+            env_cmd = ['env'] + ['%s="%s"' % (k, v) for k, v in env.items()]
         else:
             env_cmd = []
         remote_cmd = ' '.join(env_cmd + cmd)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65960.214184.patch
Type: text/x-patch
Size: 602 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190808/afaae02f/attachment-0001.bin>


More information about the llvm-commits mailing list