[PATCH] D65948: [MCA] Add flag -show-encoding to llvm-mca.

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 09:47:09 PDT 2019


andreadb added a comment.

In D65948#1621331 <https://reviews.llvm.org/D65948#1621331>, @lebedev.ri wrote:

> In D65948#1621321 <https://reviews.llvm.org/D65948#1621321>, @RKSimon wrote:
>
> > In D65948#1621314 <https://reviews.llvm.org/D65948#1621314>, @andreadb wrote:
> >
> > > In D65948#1621308 <https://reviews.llvm.org/D65948#1621308>, @lebedev.ri wrote:
> > >
> > > > Is it already transitively enabled by `-all-stats`/`-all-views`, i think not?
> > >
> > >
> > > No it is not.
> >
> >
> > TBH I'd prefer that this is disabled by default - it bulks out the instruction view quite a bit
>
>
> By default - i totally agree. But not by an explicit "please show me everything; no but really please do".


To me, "enable all views" doesn't mean "show me everything". It literally means that all the views should contribute to the final report.
Extra flags like `-show-encoding` could then be used to further customize the output.
This is at least how I see it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65948/new/

https://reviews.llvm.org/D65948





More information about the llvm-commits mailing list