[PATCH] D65673: [MBP] Disable aggressive loop rotate in plain mode

[David Li via Phabricator via llvm-commits]

davidxl requested changes to this revision.
davidxl added a comment.
This revision now requires changes to proceed.

See Some minor name suggestions, also

1. the new test cases added in the previous patch should use --force-precise-rotation-cost option to avoid losing test coverage;
2. the unrelated tests should restore to the exactly the same behavior as before.



================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:1960
+    const BlockFilterSet &LoopBlockSet,
+    bool PlainMode) {
   // Check that the header hasn't been fused with a preheader block due to
----------------
Change PlainMode to 'hasStaticProfileOnly'


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:2075
+MachineBasicBlock *
+MachineBlockPlacement::findBestLoopTopPlain(
+    const MachineLoop &L,
----------------
findBestLoopTopPlain --> findBestLoopTopNoProfile


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65673/new/

https://reviews.llvm.org/D65673