[PATCH] D60943: Delay diagnosing asm constraints that require immediates until after inlining

Bill Wendling via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 7 12:37:54 PDT 2019


void added a comment.

In D60943#1619579 <https://reviews.llvm.org/D60943#1619579>, @JamesNagurne wrote:

> In case you haven't seen, this commit breaks non-x86 build bots due to the combination of '-triple x86_64*' and '-S'. Some tests that use this target are only looking for AST dumps, and do not actually require such a target. This is not one of those tests, as it's inspecting assembly.
>  See clang/test/CodeGen/addrsig.c to see how that is handled (via REQUIRES: x86-registered-target).
>
> Oddly enough, other tests that use -triple x86_64* and only inspect the AST don't require the registered target.


Sorry about that. Fixed in r368202.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60943/new/

https://reviews.llvm.org/D60943





More information about the llvm-commits mailing list