[PATCH] D65930: [IntrinsicEmitter] Support scalable vectors in intrinsics

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 06:45:26 PDT 2019


c-rhodes added a comment.

In D65930#1620641 <https://reviews.llvm.org/D65930#1620641>, @sdesmalen wrote:

> Specifically to assert that passing a fixed-width vector where a scalable vector is expected (and vice-versa), fails.


I'm not sure such a test provides much value, the test will fail but I don't think it would test anything in the context of this patch, I'm not sure exactly where the error will come from but maybe the IR Verifier?

If we want to test the type constraints for scalable/non-scalable vectors maybe we could add an any type for scalable vectors e.g. `any_scalable_vector_type`, this could give us tighter type constraints for intrinsics that only work with scalable vectors and hopefully something to test.

I'd be happy to move the intrinsic definitions from the follow-on patch to at least have a test here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65930/new/

https://reviews.llvm.org/D65930





More information about the llvm-commits mailing list