[PATCH] D65942: Disallow implicit conversion from const char* to bool in llvm::toStringRef

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 05:43:00 PDT 2019


labath added a reviewer: dblaikie.
labath added a subscriber: dblaikie.
labath added a comment.

+ at dblaikie. I know who would the llvm owner here be, but he's probably close enough.

I think this is definitely a good idea, but I'm wondering if we shouldn't take this one step further, and disallow any implicit conversions to bool for this function. Or at least conversions from pointer types...


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65942/new/

https://reviews.llvm.org/D65942





More information about the llvm-commits mailing list