[PATCH] D62007: [RISCV] Minimal stack realignment support

[Alex Bradbury via Phabricator via llvm-commits]

asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

Please to submit a follow-on patch for targetHandlesStackFrameRounding

Is there a reason why you want tests cases for all 32/64/128/256/512/1024/2048 alignment? It feels like 32, 2048, and 4096 would give sufficient coverage?



================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:301
+    // If the stack was realigned, the frame pointer is set in order to allow
+    // SP to be restored, but we still stack objects using SP.
+    FrameReg = RISCV::X2;
----------------
still stack => still access stack


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62007/new/

https://reviews.llvm.org/D62007