[PATCH] D65583: [ARM] MVE big endian loads/stores

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 01:23:21 PDT 2019


samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:4789
+  def  : Pat<(v4i1 (load t2addrmode_imm7<2>:$addr)),
+             (v4i1 (VLDR_P0_off t2addrmode_imm7<2>:$addr))>;
 }
----------------
Do we support v2i1 as well?


================
Comment at: llvm/test/CodeGen/Thumb2/mve-loadstore.ll:16
+; CHECK-BE-NEXT:    vshr.u32 q1, q0, #1
+; CHECK-BE-NEXT:    vrev64.32 q0, q1
+; CHECK-BE-NEXT:    bx lr
----------------
So why not vrev32? I'm having real difficulty understanding why these vrev instructions are augmented with 'size'.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65583/new/

https://reviews.llvm.org/D65583





More information about the llvm-commits mailing list