[PATCH] D65367: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 2]

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 01:12:59 PDT 2019


grimar added inline comments.


================
Comment at: llvm/include/llvm/Object/MutableELFObject.h:197
+               : DynSymbols;
+  }
+
----------------
abrachet wrote:
> grimar wrote:
> > What about implementing `const` version using `non-const`? I.e. call `getWhichTable` from `getWhichTable const`.
> How do I do this without const_casting `this`? Is that how you do it? This is very useful because this duplicating methods like this has been bugging me recently. Thanks!
I think there is no way to do this without `const_cast`, but this is a normal/common way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65367/new/

https://reviews.llvm.org/D65367





More information about the llvm-commits mailing list