[PATCH] D65924: Revert "[cmake] Pass LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN to NATIVE configure"

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 7 22:45:10 PDT 2019


jfb abandoned this revision.
jfb added a comment.

In D65924#1620383 <https://reviews.llvm.org/D65924#1620383>, @smeenai wrote:

> In D65924#1620382 <https://reviews.llvm.org/D65924#1620382>, @jfb wrote:
>
> > In D65924#1620379 <https://reviews.llvm.org/D65924#1620379>, @smeenai wrote:
> >
> > > I take it LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN will be going away entirely? If so, LGTM.
> >
> >
> > I intend to leave it there so it's easy to do the same dance for the next compiler bump. It won't be active for a bit, but we also won't have to re-agree on how to bump the version next time around :)
>
>
> In that case, is there any harm to leaving this one around? It'll be a no-op for now, but we'd need this next time around too.


Hmm, I think you're right! Let's leave it as-is then!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65924/new/

https://reviews.llvm.org/D65924





More information about the llvm-commits mailing list