[PATCH] D65832: [llvm-readelf] Implement NT_FILE core file parsing

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 7 11:16:22 PDT 2019


rupprecht updated this revision to Diff 213955.
rupprecht marked 12 inline comments as done.
rupprecht added a comment.

- Remove ET_CORE check
- null -> NUL
- Use more consistent error messages
- Check for no more lines in test output
- Other misc cleanup


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65832/new/

https://reviews.llvm.org/D65832

Files:
  llvm/test/tools/llvm-readobj/note-core-ntfile-bad.test
  llvm/test/tools/llvm-readobj/note-core-ntfile.test
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65832.213955.patch
Type: text/x-patch
Size: 14322 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190807/0ef54218/attachment.bin>


More information about the llvm-commits mailing list