[PATCH] D64825: Enable assembly output of local commons for AIX

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 7 09:42:20 PDT 2019


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1833
     getNameWithPrefix(Name, GO, TM);
-    return getContext().getXCOFFSection(Name, XCOFF::XMC_RW, XCOFF::XTY_CM,
-                                        Kind, /* BeginSymbolName */ nullptr);
+    return getContext().getXCOFFSection(
+        Name, Kind.isBSSLocal() ? XCOFF::XMC_BS : XCOFF::XMC_RW, XCOFF::XTY_CM,
----------------
One or the other of D65159 or this needs to be rebased on the other when one lands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64825/new/

https://reviews.llvm.org/D64825





More information about the llvm-commits mailing list