[PATCH] D65888: [UpdateTestChecks] Drop and update test checks

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 7 08:56:50 PDT 2019


lebedev.ri added a comment.

This is hard-coding `CHECK` prefix, it wouldn't work for any other prefix,
even if it's specified for FileCheck. Though even then if you re-use the prefixes
from FileCheck, it still will leave check lines that are no longer check
lines because that prefix is no longer mentioned in FileCheck.

In other words, i'm personally honestly not seeing usefulness of this.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65888/new/

https://reviews.llvm.org/D65888





More information about the llvm-commits mailing list