[PATCH] D65515: [llvm-readobj/libObject] - Introduce a custom warning handler for `ELFFile<ELFT>` methods.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-readobj/elf-wrong-shstrtab-type.test:4
 
+## Check we report a warning about issue only once for an input object.
+
----------------
I'd rephrase:

Check we report only one warning for the issue for each input object.


================
Comment at: test/tools/llvm-readobj/elf-wrong-shstrtab-type.test:20
+
+## Test we report multiple identical warnings (a one for each object) when dumping an archive.
+
----------------
a one -> one


================
Comment at: test/tools/llvm-readobj/elf-wrong-shstrtab-type.test:29-31
+# AR-LLVM:  Section {
+# AR-LLVM:    Name: .shstrtab
+# AR-LLVM:    Type: SHT_PROGBITS
----------------
Do we really need these lines for this and the following test cases? We already show that we can dump the  section as well as warn above.


================
Comment at: test/tools/llvm-readobj/elf-wrong-shstrtab-type.test:54
+
+## Test we report the warning for each input file specified in the command line.
 
----------------
in -> on


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65515/new/

https://reviews.llvm.org/D65515