[PATCH] D65380: [InstCombine] Shift amount reassociation: shl-trunc-shl pattern

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 7 02:40:06 PDT 2019


lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.

In D65380#1617668 <https://reviews.llvm.org/D65380#1617668>, @rnk wrote:

> The assertion and stack trace:
>  https://reviews.llvm.org/P8158
>  clang: /usr/local/google/home/rnk/llvm-project/llvm/lib/IR/Constants.cpp:1864: static llvm::Constant *llvm::ConstantExpr::get(unsigned int, llvm::Constant *, llvm::Constant *
>  , unsigned int, llvm::Type *): Assertion `C1->getType() == C2->getType() && "Operand types in binary constant expression should match"' failed.
>
>   #9 0x0000000003ca39ae llvm::ConstantExpr::get(unsigned int, llvm::Constant*, llvm::Constant*, unsigned int, llvm::Type*) /usr/local/google/home/rnk/llvm-project/llvm/lib/IR/
>
> Constants.cpp:1896:5                                                                                                                                                          
>  #10 0x00000000036e4fec llvm::ConstantFoldBinaryOpOperands(unsigned int, llvm::Constant*, llvm::Constant*, llvm::DataLayout const&) /usr/local/google/home/rnk/llvm-project/llv
>  m/lib/Analysis/ConstantFolding.cpp:1286:10


Sorry for that and thanks for the revert.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65380/new/

https://reviews.llvm.org/D65380





More information about the llvm-commits mailing list