[PATCH] D65585: WIP: [llvm-locstats] Add the llvm-locstats tool

[Djordje Todorovic via llvm-commits]

Thank you all for valuable comments! I was away for a few days and sorry for the late response.

Vedant, Adrian,

>>> I take your point about not wanting to clutter up llvm-dwarfdump --statistics output.
>>>
>>> I'll note that, beyond code sharing, there are significant benefits to emitting all `locstats` information using the existing `--statistics` option:
>>>
>>> 1) We can check in a simple script in utils/ to pretty-print the `--statistics` JSON output, such that we get exactly what is emitted by the `locstats` tool today.
>>>
>>> 2) Emitting stats in JSON is great for continuous integration jobs that track debug info quality over time. It'd be great to include the metrics reported by `locstats` in these jobs.
>> 
>> And I should point out that this is not a hypothetical scenario. This job:
>> 
>> http://green.lab.llvm.org/green/view/LLDB/job/clang-3.4-debuginfo-statistics/
>> 
>> Pushes data into:
>> 
>> http://lnt.llvm.org/db_default/v4/nts/machine/1357
>> 
>> which generates graphs like:
>> 
>> http://lnt.llvm.org/db_default/v4/nts/graph?plot.0=1357.1607043.4&highlight_run=127815
>> 
>> several times per hour. Any new JSON fields show up there without any extra manual intervention.

This is very helpful and I agree we could add a script into the 'utils/' that can do the 'locstats' job instead!

I just wanted to emphasize (and correct my self if I was expressed in a wrong way) that I did not want to say that adding extra fields to the 'llvm-dwarfdump' stats is expensive, but I wanted to say that having a separate (sub)tool (or the utils script) improves the stats reporting in a human (user) friendly way (by pretty-printing and encapsulating the locations stats job).

Best regards,
Djordje


On 5.8.19. 18:49, Adrian Prantl wrote:
> 
> 
>> On Aug 2, 2019, at 6:10 PM, vsk at apple.com <mailto:vsk at apple.com> wrote:
>>
>> Hi Djordje,
>>
>> I take your point about not wanting to clutter up llvm-dwarfdump --statistics output.
>>
>> I'll note that, beyond code sharing, there are significant benefits to emitting all `locstats` information using the existing `--statistics` option:
>>
>> 1) We can check in a simple script in utils/ to pretty-print the `--statistics` JSON output, such that we get exactly what is emitted by the `locstats` tool today.
>>
>> 2) Emitting stats in JSON is great for continuous integration jobs that track debug info quality over time. It'd be great to include the metrics reported by `locstats` in these jobs.
> 
> And I should point out that this is not a hypothetical scenario. This job:
> 
> http://green.lab.llvm.org/green/view/LLDB/job/clang-3.4-debuginfo-statistics/
> 
> Pushes data into:
> 
> http://lnt.llvm.org/db_default/v4/nts/machine/1357
> 
> which generates graphs like:
> 
> http://lnt.llvm.org/db_default/v4/nts/graph?plot.0=1357.1607043.4&highlight_run=127815
> 
> several times per hour. Any new JSON fields show up there without any extra manual intervention.
> 
> -- adrian