[PATCH] D65497: [RISCV] Avoid generating AssertZext for RV64 when lowering floating Libcall

[Shiva Chen via Phabricator via llvm-commits]

shiva0217 marked 2 inline comments as done.
shiva0217 added inline comments.


================
Comment at: include/llvm/CodeGen/TargetLowering.h:1834
+                                         bool IsCastFromFloat) const {
+    return IsExtended;
+  }
----------------
efriedma wrote:
> Can the target actually do anything useful with the "IsExtended" boolean?  I think it makes more sense to just write something like `IsExtended && shouldExtendTypeInLibCall(Type, IsCastFromFloat)` in the caller.
Removing "IsExtended" from argument lists seems much cleaner, thanks. :)


================
Comment at: test/CodeGen/RISCV/rv64-complex-float.ll:133
+; CHECK-NEXT:    slli a0, s5, 32
+; CHECK-NEXT:    srli a0, a0, 32
+; CHECK-NEXT:    mv a1, a0
----------------
efriedma wrote:
> More unnecessary shifts.
Thanks for catching this.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65497/new/

https://reviews.llvm.org/D65497