[PATCH] D65722: [ELF] Expand regions for gaps due to explicit address

Tue Aug 6 15:09:09 PDT 2019

yodaldevoid added a comment.

In D65722#1616707 <https://reviews.llvm.org/D65722#1616707>, @MaskRay wrote:

> I can commit but I'd like @ruiu to take a look first.

Understandable.

================
Comment at: lld/test/ELF/linkerscript/memory-gap-explicit-expr.test:8
+# RUN: llvm-readelf -S %t | FileCheck %s
+# CHECK: .aaa_s PROGBITS 0000000000000000 001000 000008
+# CHECK: .bbb_s PROGBITS 0000000000000014 001014 000008
----------------
MaskRay wrote:
> Any particular reason the output section is `.aaa_s` while the input section is `.aaa`. I don't think that matters but it may make people puzzled
I made it `.aaa_s` when debugging so that I could differentiate printouts referring to sections as defined in the "program" and sections as defined in the linker script.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65722/new/

https://reviews.llvm.org/D65722