[PATCH] D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG

Tue Aug 6 14:06:18 PDT 2019

akhuang marked 3 inline comments as done.
akhuang added inline comments.

================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:4062
+    if (CLI.CS && CLI.CS->getMetadata("heapallocsite"))
+      DAG.addHeapAllocSite(Ret.getNode(), CLI.CS->getMetadata("heapallocsite"));
+
----------------
rnk wrote:
> I thought testing showed that MSVC didn't emit these records for tail calls. If we simply do nothing here, we'd skip the S_HEAPALLOCSITE record, and things would keep working, right? Any reason not to do that?
Yeah, not sure why I added it back here. I removed it, but some `invalid symbol redefinition`s are still occurring.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65023/new/

https://reviews.llvm.org/D65023