[PATCH] D65821: [Attributor][modulemap] Revert r368064 but fix the build

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 6 12:07:22 PDT 2019


jdoerfert created this revision.
jdoerfert added reviewers: kristina, aprantl.
Herald added subscribers: bollu, hiraditya.
Herald added a project: LLVM.

Commit r368064 was necessary after r367953 (D65712 <https://reviews.llvm.org/D65712>) broke the module
build. That happened, apparently, because the template class IRAttribute
defined in the header had a virtual method defined in the corresponding
source file (IRAttribute::manifest). To unbreak the situation this patc
introduces a helper function IRAttributeManifest::manifestAttrs which
is used to implement IRAttribute::manifest in the header. The deifnition
of the helper function is still in the source file.


https://reviews.llvm.org/D65821

Files:
  llvm/include/llvm/Transforms/IPO/Attributor.h
  llvm/include/llvm/module.modulemap
  llvm/lib/Transforms/IPO/Attributor.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65821.213681.patch
Type: text/x-patch
Size: 3998 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190806/6e7c7b4a/attachment.bin>


More information about the llvm-commits mailing list