[PATCH] D65809: [ARM] Expand CTPOP instruction for MVE

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/test/CodeGen/Thumb2/ctpop.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=thumbv8.1m.main-arm-none-eabi -mattr=+mve.fp -verify-machineinstrs %s -o - | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-MVE
+
----------------
You can drop the --check-prefix=CHECK and --check-prefix=CHECK-MVE as there is only one run line.


================
Comment at: llvm/test/CodeGen/Thumb2/ctpop.ll:4
+
+define <2 x i32> @ctpop_i32_t(<2 x i32> %src){
+; CHECK-LABEL: ctpop_i32_t:
----------------
Can you:
- change this one to a <4 x i32>
- you add tests for <8 x i16> and <16 x i8> too.
- probably add a <2 x i64> test too.
That will cover all the interesting bases.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65809/new/

https://reviews.llvm.org/D65809