[PATCH] D64665: [MachinePipeliner] Refactor schedule emission logic

James Molloy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 6 03:06:44 PDT 2019


jmolloy updated this revision to Diff 213562.
jmolloy added a comment.

Thanks Jinsong!

Your patch got reverted, so I patched it in locally and fixed all the issues it raised. The new experimental codegen now produces almost-bit-accurate results for your testcases. There is a little permutation (we emit prologs in pipelined order rather than emitting stages separately) but I've validated that the code produced is the same.

I'd be really keen for any additional testing you could throw at this, including runtime tests!

Cheers,

James


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64665/new/

https://reviews.llvm.org/D64665

Files:
  include/llvm/CodeGen/MachinePipeliner.h
  lib/CodeGen/MachineLoopUtils.cpp
  lib/CodeGen/MachineLoopUtils.h
  lib/CodeGen/MachinePipeliner.cpp
  test/CodeGen/Hexagon/swp-epilog-phi11.ll
  test/CodeGen/Hexagon/swp-epilog-phi6.ll
  test/CodeGen/Hexagon/swp-epilog-phi7.ll
  test/CodeGen/Hexagon/swp-matmul-bitext.ll
  test/CodeGen/Hexagon/swp-xxh2.ll
  test/CodeGen/PowerPC/sms-phi.ll
  test/CodeGen/PowerPC/sms-simple.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64665.213562.patch
Type: text/x-patch
Size: 47050 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190806/438a86fc/attachment.bin>


More information about the llvm-commits mailing list