[PATCH] D65391: [ELF.h] - Check the case when e_shstrndx=SHN_XINDEX, but the corresponding sh_link is broken.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 6 03:01:10 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with nits fixed. Sorry, last week was very busy. Just working through my backlog now.



================
Comment at: test/Object/invalid.test:632
+## Check the case when e_shstrndx == SHN_XINDEX, but sh_link in the section header at index 0
+## contains index of section header string table that is larger than number of the sections.
+
----------------
contains the index of a
larger than the number


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65391/new/

https://reviews.llvm.org/D65391





More information about the llvm-commits mailing list