[PATCH] D65788: [ADT] Remove O(1) requirement to range passed to llvm::size

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 6 02:09:37 PDT 2019


jhenderson added a comment.

How many places use this and in what context? I'm conscious of std::size which becomes available in C++17, and the natural implementation of that is to simply use the standard .size() method on a container (see https://en.cppreference.com/w/cpp/iterator/size). It also does something else for fixed-sized arrays, but this particular version doesn't work for that. Finally, why do you need llvm::size() instead of a container.size() method?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65788/new/

https://reviews.llvm.org/D65788





More information about the llvm-commits mailing list