[PATCH] D65702: [FileCheck] Move -dump-input diagnostic to first line

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre accepted this revision.
thopre added a comment.
This revision is now accepted and ready to land.

In D65702#1614927 <https://reviews.llvm.org/D65702#1614927>, @jdenny wrote:

> In D65702#1614906 <https://reviews.llvm.org/D65702#1614906>, @thopre wrote:
>
> > Does this work for multiline annotations? If I read this correctly (I often don't so my apologies if that's the case) it will print the marker for each line in a multiline annotation except the last.
>
>
> It works correctly for the multi-line annotations I've tested: it prints the note (like `error: no match found`) only for the first line.  See the test suite changes and the summary for examples.  Does that help?  Thanks for reviewing.


Ah my bad I think I understand it now. The first line is dealt with outside the loop by the Annotations.push_back(A) which will print a note. The other lines, dealt in the loop, get an empty note and thus nothing besides the markers. LGTM then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65702/new/

https://reviews.llvm.org/D65702