[PATCH] D65748: [LLVM][Alignment] Introduce Alignment In GlobalObject

[JF Bastien via Phabricator via llvm-commits]

jfb accepted this revision.
jfb added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/IR/GlobalObject.h:67
+  /// Prefer the setter taking a MaybeAlign, this one is being phased out.
   void setAlignment(unsigned Align);
+  void setAlignment(MaybeAlign Align);
----------------
Can you leave a FIXME on this line instead of the comment above?


================
Comment at: llvm/include/llvm/Support/Alignment.h:104
     assert((Value == 0 || llvm::isPowerOf2_64(Value)) &&
-           "Alignment is not 0 or a power of 2");
+           "Alignment is not 0 nor a power of 2");
     if (Value)
----------------
neither / nor?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65748/new/

https://reviews.llvm.org/D65748