[PATCH] D65550: [AArch64] Do not emit '#' before immediates in inline asm

Pirama Arumuga Nainar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 15:38:10 PDT 2019


pirama added a comment.

In D65550#1610801 <https://reviews.llvm.org/D65550#1610801>, @efriedma wrote:

> This only affects inline asm, it looks like, not general instructions? (I looked briefly, and it looks like instructions go through AArch64InstPrinter::printOperand instead.)
>
> I don't think this would cause any issues off the top of my head, but you might want to run something like an Android build to confirm that.


I built Android with this change and except for one issue [1], the build is successful.

[1] a python script that had the '#' in a regular expression when searching the emitted inline assembly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65550/new/

https://reviews.llvm.org/D65550





More information about the llvm-commits mailing list