[PATCH] D65035: [DebugInfo] Don't emit incorrect descriptions of thunk params (PR42627)

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 15:04:46 PDT 2019


dblaikie added a comment.

In D65035#1615787 <https://reviews.llvm.org/D65035#1615787>, @aprantl wrote:

> It's likely better for the tools to know where each function starts *and ends*.


__attribute__((nodebug)) breaks that invariant (& I think there's other functions we emit without debug info too - maybe some things to do with global ctors?)

> More importantly though, if we don't generate debug info for the thunk, can we describe the function itself after it became inlined into the thunk?

Not really, no - and GCC doesn't describe the inlining either. A backtrace would demangle the name of the thunk & that's about all it could show there.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65035/new/

https://reviews.llvm.org/D65035





More information about the llvm-commits mailing list