[PATCH] D65768: hwasan: Untag global variable addresses in tests.

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 14:35:00 PDT 2019


hctim accepted this revision.
hctim added a comment.
This revision is now accepted and ready to land.

LGTM with nits.



================
Comment at: compiler-rt/test/hwasan/TestCases/utils.h:10
+
+__attribute__((no_sanitize("hwaddress"))) int untag_printf(const char *fmt, ...) {
+  va_list ap;
----------------
Nit: > 80char


================
Comment at: compiler-rt/test/hwasan/TestCases/utils.h:18
+
+__attribute__((no_sanitize("hwaddress"))) int untag_fprintf(FILE *stream, const char *fmt, ...) {
+  va_list ap;
----------------
Nit: > 80char


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65768/new/

https://reviews.llvm.org/D65768





More information about the llvm-commits mailing list