[PATCH] D65777: [GlobalISel][NFC] Factor out common target code from GlobalISelEmitter tests

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 14:25:09 PDT 2019


paquette created this revision.
paquette added reviewers: arsenm, dsanders.
Herald added subscribers: Petar.Avramovic, rovka, wdng.
Herald added a project: LLVM.
paquette added a parent revision: D65756: [GlobalISel] Teach GlobalISelEmitter to treat used iPTRAny operands as pointer operands.

Factor out commonly-used target code from the GlobalISelEmitter tests into a GlobalISelEmitterCommon.td file. This is still tested by the original GlobalISelEmitter.td test.

This reduces the amount of boilerplate code necessary for writing tests for the GlobalISelEmitter.

I don't have many strong opinions on how this is split up, so if there's a better way to do it, I'm happy to change it. I tried to keep it to things like types which people would expect to have by default.


https://reviews.llvm.org/D65777

Files:
  llvm/test/TableGen/Common/GlobalISelEmitterCommon.td
  llvm/test/TableGen/GlobalISelEmitter-PR39045.td
  llvm/test/TableGen/GlobalISelEmitter.td
  llvm/test/TableGen/GlobalISelEmitterOverloadedPtr.td
  llvm/test/TableGen/GlobalISelEmitterSkippedPatterns.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65777.213463.patch
Type: text/x-patch
Size: 6736 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190805/ad9498b3/attachment.bin>


More information about the llvm-commits mailing list