[PATCH] D62445: [test] Fix plugin tests

Don Hinton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 14:09:54 PDT 2019


hintonda added a comment.

In D62445#1613268 <https://reviews.llvm.org/D62445#1613268>, @NoQ wrote:

> Ugh, there seems to be one more forgotten buildbot with plugins problems: http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6406/consoleText


<snip>

> It got suddenly fixed in http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6409/ but then immediately failed again later and it's still failing in a similar manner, and nobody noticed for two months =/

The fix was accidental and fortuitous.

r362399 tried to set LLVM_ENABLE_PLUGINS_default to the value of LLVM_ENABLE_PIC, but had a typo that actually turn off LLVM_ENABLE_PLUGINS, so the test was marked unsupported in build #6409.  That typo was fixed in r362492 which caused the next build, #6411 and all subsequent builds, to fail.

Will now look into cause/fix.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62445/new/

https://reviews.llvm.org/D62445





More information about the llvm-commits mailing list