[PATCH] D65756: [GlobalISel] Teach GlobalISelEmitter to treat used iPTRAny operands as pointer operands

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 14:00:23 PDT 2019


paquette marked an inline comment as done.
paquette added inline comments.


================
Comment at: llvm/test/TableGen/GlobalISelEmitterOverloadedPtr.td:6
+
+def MyTargetISA : InstrInfo;
+def MyTarget : Target { let InstructionSet = MyTargetISA; }
----------------
arsenm wrote:
> paquette wrote:
> > arsenm wrote:
> > > A lot of tests have the same fake target boilerplate. Should these be merged into a template target to include?
> > I think that's a good idea, but I'm not quite sure how to get TableGen to do it.
> I think just an include will work, although I'm not sure where to put it
I managed to get it working locally, but it makes the patch kind of large. I think it would be better to do in a follow-up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65756/new/

https://reviews.llvm.org/D65756





More information about the llvm-commits mailing list