[PATCH] D65768: hwasan: Untag global variable addresses in tests.

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 13:37:22 PDT 2019


hctim added a comment.

Understood. I'm not the biggest fan of putting macros all around the codebase - could we define our own `ErrorPrintf()/Printf()/strcmp()` and explicitly untag there? I think relying on explicit untagging everywhere may be error-prone, and it looks like we can reduce the mental overhead of remembering to explicitly untag.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65768/new/

https://reviews.llvm.org/D65768





More information about the llvm-commits mailing list