[PATCH] D65760: [ORC] Add host CPU name and sub-target features to JITTargetMachineBuilder::detectHost()

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 12:57:27 PDT 2019


lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

Looks good to me. Thanks Diego!

I think it's ok to commit without a test for now. If detectHost() starts getting more complicated we could add a unit test to verify its behavior (basically: the resulting JTMB's fields match the values from getHostCPUName/getHostCPUFeatures/whatever-else-we-add). I don't think we need that yet though.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65760/new/

https://reviews.llvm.org/D65760





More information about the llvm-commits mailing list