[llvm] r367900 - Robustify update_test_checks.py to non-autogened tests, and add a mode to skip non-autogenerated ones

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 11:25:08 PDT 2019


Author: reames
Date: Mon Aug  5 11:25:08 2019
New Revision: 367900

URL: http://llvm.org/viewvc/llvm-project?rev=367900&view=rev
Log:
Robustify update_test_checks.py to non-autogened tests, and add a mode to skip non-autogenerated ones

Intended use case is:
./utils/update_test_checks.py test/Transform/PassDir/* --update-only
(i.e. rapidly be able to see changes in autogened filed, before handing non-autogened tests individually)

Differential Revision: https://reviews.llvm.org/D65610


Modified:
    llvm/trunk/utils/update_test_checks.py

Modified: llvm/trunk/utils/update_test_checks.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/update_test_checks.py?rev=367900&r1=367899&r2=367900&view=diff
==============================================================================
--- llvm/trunk/utils/update_test_checks.py (original)
+++ llvm/trunk/utils/update_test_checks.py Mon Aug  5 11:25:08 2019
@@ -62,6 +62,8 @@ def main():
                       help='The opt binary used to generate the test case')
   parser.add_argument(
       '--function', help='The function in the test file to update')
+  parser.add_argument('--update-only', action='store_true',
+                      help='Only update test if it was already autogened')
   parser.add_argument('tests', nargs='+')
   args = parser.parse_args()
 
@@ -86,6 +88,11 @@ def main():
     with open(test) as f:
       input_lines = [l.rstrip() for l in f]
 
+    if args.update_only:
+      if len(input_lines) == 0 or 'autogenerated' not in input_lines[0]:
+        print('Skipping test which isn\'t autogenerated: %s' % (test), file=sys.stderr)
+        continue;
+
     raw_lines = [m.group(1)
                  for m in [common.RUN_LINE_RE.match(l) for l in input_lines] if m]
     run_lines = [raw_lines[0]] if len(raw_lines) > 0 else []
@@ -102,6 +109,10 @@ def main():
 
     prefix_list = []
     for l in run_lines:
+      if '|' not in l:
+        print('WARNING: Skipping unparseable RUN line: %s' % (l,), file=sys.stderr)
+        continue
+        
       (tool_cmd, filecheck_cmd) = tuple([cmd.strip() for cmd in l.split('|', 1)])
       common.verify_filecheck_prefixes(filecheck_cmd)
       if not tool_cmd.startswith(opt_basename + ' '):




More information about the llvm-commits mailing list