[PATCH] D65226: [Strict FP] Allow custom operation actions

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 11:18:13 PDT 2019


hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

In D65226#1615192 <https://reviews.llvm.org/D65226#1615192>, @kpn wrote:

> In D65226#1615137 <https://reviews.llvm.org/D65226#1615137>, @uweigand wrote:
>
> > Ping?
> >
> > Should we move ahead with this?  I believe this is still a pre-req for D63782 <https://reviews.llvm.org/D63782> ...
>
>
> I have no objections. I'll defer to one of the other reviewers.
>
> I'm still not thrilled with the tricky doing nothing but returning true code like I mentioned, but I don't think that should be enough to hold things up.


LGTM. It does not look like there are any outstanding objections.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65226/new/

https://reviews.llvm.org/D65226





More information about the llvm-commits mailing list