[PATCH] D65756: [GlobalISel] Teach GlobalISelEmitter to treat used iPTRAny operands as pointer operands

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 10:25:10 PDT 2019


arsenm added inline comments.


================
Comment at: llvm/test/TableGen/GlobalISelEmitterOverloadedPtr.td:6
+
+def MyTargetISA : InstrInfo;
+def MyTarget : Target { let InstructionSet = MyTargetISA; }
----------------
A lot of tests have the same fake target boilerplate. Should these be merged into a template target to include?


================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:3499
+    if (IsIntrinsic && !II)
+      return failedImport("Expected IntInit containing instrinsic ID)");
+
----------------
instrinsic 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65756/new/

https://reviews.llvm.org/D65756





More information about the llvm-commits mailing list