[PATCH] D65644: [AMDGPU] gfx10 atomic optimizer changes.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 08:00:01 PDT 2019


foad marked an inline comment as done.
foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp:293
+  }
+  if (ST->getGeneration() < AMDGPUSubtarget::GFX10) {
+    // GFX9 has DPP row broadcast operations.
----------------
arsenm wrote:
> I'm trying to avoid explicit getGeneration checks everywhere, and restricting them to all be in the Subtarget. 
You mean I should define and use some more specific properties like `hasDPPBroadcasts` and `hasDPPWavefrontShifts`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65644/new/

https://reviews.llvm.org/D65644





More information about the llvm-commits mailing list