[PATCH] D65716: [ELF] Consistently priority non-* wildcards overs "*" in version scripts

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 05:22:56 PDT 2019


grimar added a comment.

Minor nit is below and I do not have any more comments atm probably, looks good to me.



================
Comment at: ELF/Config.h:310
 
+static inline ArrayRef<VersionDefinition> versionDefinitionsNotLocalOrGlobal() {
+  return llvm::makeArrayRef(config->versionDefinitions).slice(2);
----------------
`versionDefinitionsNotLocalOrGlobal` looks a bit too long name.
May be `namedVersionDefs` or something else would be better?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65716/new/

https://reviews.llvm.org/D65716





More information about the llvm-commits mailing list