[PATCH] D65565: [LLD] [COFF] Fix wholearchive with thin archives

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 00:35:42 PDT 2019


hans added a comment.

In D65565#1612908 <https://reviews.llvm.org/D65565#1612908>, @mstorsjo wrote:

> In D65565#1612269 <https://reviews.llvm.org/D65565#1612269>, @orgads wrote:
>
> > > The commit doesn't merge cleanly to the release_90 branch.
> > > 
> > > If you think it would be useful to merge this, could you prepare a diff that applies cleanly to the branch? Doing it against the git monorepo might be easiest.
> >
> > The change in Driver.cpp does apply cleanly. The test file just doesn't exist in 9.0. Do you need the test?
>
>
> A backport to the 9.x branch on the monorepo, including a test, is available at https://martin.st/temp/0001-COFF-Fix-wholearchive-with-thin-archives.patch. I picked the tests from the earlier commit on master, minus the tests for the new stuff in the commit that actually added them, but with the tests for wholearchive+thin instead.


Many thanks! Committed that to the branch in r367806.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65565/new/

https://reviews.llvm.org/D65565





More information about the llvm-commits mailing list