[PATCH] D65711: [Attributor][NFCI] Make abstract attributes stateless

Stefan Stipanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 4 16:46:19 PDT 2019


sstefan1 added a comment.

I really like both this and D65712 <https://reviews.llvm.org/D65712>. This makes things much cleaner imo. One more question, since D65712 <https://reviews.llvm.org/D65712> also simplifies some things from this patch, wouldn't it be easier to just make it in one review?



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:407
   /// {
   AbstractState &getState() override { return *this; }
   const AbstractState &getState() const override { return *this; }
----------------
Can these getState() overrides be also put in the above macro? As far as I can see they are also always same.
This would also apply to D65712, for IRAttribute.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65711/new/

https://reviews.llvm.org/D65711





More information about the llvm-commits mailing list