[lld] r367778 - [ELF][test] Delete redundant version-script-*.s tests

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 4 02:05:22 PDT 2019


Author: maskray
Date: Sun Aug  4 02:05:21 2019
New Revision: 367778

URL: http://llvm.org/viewvc/llvm-project?rev=367778&view=rev
Log:
[ELF][test] Delete redundant version-script-*.s tests

Delete version-script-missing.s: it is covered by version-script-noundef.s
Delete version-script-anonymous-local.s: it is covered by version-script-{glob,weak}.s etc
Delete version-script-no-warn{,2}.s: add --fatal-warnings to some version-script.s commands instead

Removed:
    lld/trunk/test/ELF/version-script-anonymous-local.s
    lld/trunk/test/ELF/version-script-missing.s
    lld/trunk/test/ELF/version-script-no-warn.s
    lld/trunk/test/ELF/version-script-no-warn2.s
Modified:
    lld/trunk/test/ELF/version-script-noundef.s
    lld/trunk/test/ELF/version-script.s

Removed: lld/trunk/test/ELF/version-script-anonymous-local.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/version-script-anonymous-local.s?rev=367777&view=auto
==============================================================================
--- lld/trunk/test/ELF/version-script-anonymous-local.s (original)
+++ lld/trunk/test/ELF/version-script-anonymous-local.s (removed)
@@ -1,61 +0,0 @@
-# REQUIRES: x86
-# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
-
-# RUN: echo "{ global: foo; local: bar; };" > %t.script
-# RUN: ld.lld --version-script %t.script -shared %t.o -o %t.so
-# RUN: llvm-readobj --dyn-syms --symbols %t.so | FileCheck %s
-
-# CHECK:      Symbols [
-# CHECK:          Name: bar
-# CHECK-NEXT:     Value:
-# CHECK-NEXT:     Size:
-# CHECK-NEXT:     Binding: Local
-
-# CHECK:          Name: foo
-# CHECK-NEXT:     Value:
-# CHECK-NEXT:     Size:
-# CHECK-NEXT:     Binding: Global
-
-# CHECK:          Name: zed
-# CHECK-NEXT:     Value:
-# CHECK-NEXT:     Size:
-# CHECK-NEXT:     Binding: Global
-
-
-# CHECK:       DynamicSymbols [
-# CHECK-NEXT:    Symbol {
-# CHECK-NEXT:     Name:
-# CHECK-NEXT:     Value:
-# CHECK-NEXT:     Size:
-# CHECK-NEXT:     Binding:
-# CHECK-NEXT:     Type:
-# CHECK-NEXT:     Other:
-# CHECK-NEXT:     Section:
-# CHECK-NEXT:   }
-# CHECK-NEXT:   Symbol {
-# CHECK-NEXT:     Name: foo
-# CHECK-NEXT:     Value:
-# CHECK-NEXT:     Size:
-# CHECK-NEXT:     Binding: Global
-# CHECK-NEXT:     Type:
-# CHECK-NEXT:     Other:
-# CHECK-NEXT:     Section:
-# CHECK-NEXT:   }
-# CHECK-NEXT:   Symbol {
-# CHECK-NEXT:     Name: zed
-# CHECK-NEXT:     Value:
-# CHECK-NEXT:     Size:
-# CHECK-NEXT:     Binding: Global
-# CHECK-NEXT:     Type:
-# CHECK-NEXT:     Other:
-# CHECK-NEXT:     Section:
-# CHECK-NEXT:   }
-# CHECK-NEXT: ]
-
-
-.global foo
-foo:
-.global bar
-bar:
-.global zed
-zed:

Removed: lld/trunk/test/ELF/version-script-missing.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/version-script-missing.s?rev=367777&view=auto
==============================================================================
--- lld/trunk/test/ELF/version-script-missing.s (original)
+++ lld/trunk/test/ELF/version-script-missing.s (removed)
@@ -1,7 +0,0 @@
-# REQUIRES: x86
-
-# We used to crash if a symbol in a version script was not in the symbol table.
-
-# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
-# RUN: echo "{ foobar; };" > %t.script
-# RUN: ld.lld --version-script %t.script -shared %t.o -o /dev/null

Removed: lld/trunk/test/ELF/version-script-no-warn.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/version-script-no-warn.s?rev=367777&view=auto
==============================================================================
--- lld/trunk/test/ELF/version-script-no-warn.s (original)
+++ lld/trunk/test/ELF/version-script-no-warn.s (removed)
@@ -1,12 +0,0 @@
-# REQUIRES: x86
-
-# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
-# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %p/Inputs/shared.s -o %t2.o
-# RUN: ld.lld -shared %t2.o -soname shared -o %t2.so
-
-# RUN: echo "foo { global: bar;  local: *; };" > %t.script
-# RUN: ld.lld --fatal-warnings --shared --version-script %t.script %t.o %t2.so -o /dev/null
-
-.global bar
-bar:
-        nop

Removed: lld/trunk/test/ELF/version-script-no-warn2.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/version-script-no-warn2.s?rev=367777&view=auto
==============================================================================
--- lld/trunk/test/ELF/version-script-no-warn2.s (original)
+++ lld/trunk/test/ELF/version-script-no-warn2.s (removed)
@@ -1,9 +0,0 @@
-# REQUIRES: x86
-# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %p/Inputs/version-script-no-warn2.s -o %t1.o
-# RUN: ld.lld %t1.o -o %t1.so -shared
-# RUN: echo "{ global: foo; local:  *; };" > %t.script
-# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t2.o
-# RUN: ld.lld -shared --version-script %t.script %t2.o %t1.so -o /dev/null --fatal-warnings
-
-.global	foo
-foo:

Modified: lld/trunk/test/ELF/version-script-noundef.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/version-script-noundef.s?rev=367778&r1=367777&r2=367778&view=diff
==============================================================================
--- lld/trunk/test/ELF/version-script-noundef.s (original)
+++ lld/trunk/test/ELF/version-script-noundef.s Sun Aug  4 02:05:21 2019
@@ -2,7 +2,7 @@
 
 # RUN: echo "VERSION_1.0 { global: bar; };" > %t.script
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
-# RUN: ld.lld --version-script %t.script -shared %t.o -o %t.so
+# RUN: ld.lld --version-script %t.script -shared %t.o -o /dev/null --fatal-warnings
 # RUN: ld.lld --version-script %t.script -shared --undefined-version %t.o -o %t.so
 # RUN: not ld.lld --version-script %t.script -shared --no-undefined-version \
 # RUN:   %t.o -o %t.so 2>&1 | FileCheck -check-prefix=ERR1 %s

Modified: lld/trunk/test/ELF/version-script.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/version-script.s?rev=367778&r1=367777&r2=367778&view=diff
==============================================================================
--- lld/trunk/test/ELF/version-script.s (original)
+++ lld/trunk/test/ELF/version-script.s Sun Aug  4 02:05:21 2019
@@ -5,7 +5,7 @@
 
 # RUN: echo "{ global: foo1; foo3; local: *; };" > %t.script
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
-# RUN: ld.lld --version-script %t.script -shared %t.o %t2.so -o %t.so
+# RUN: ld.lld --version-script %t.script -shared %t.o %t2.so -o %t.so --fatal-warnings
 # RUN: llvm-readobj --dyn-syms %t.so | FileCheck --check-prefix=DSO %s
 
 # RUN: echo "# comment" > %t3.script
@@ -17,7 +17,7 @@
 ## Also check that both "global:" and "global :" forms are accepted
 # RUN: echo "VERSION_1.0 { global : foo1; local : *; };" > %t4.script
 # RUN: echo "VERSION_2.0 { global: foo3; local: *; };" >> %t4.script
-# RUN: ld.lld --version-script %t4.script -shared %t.o %t2.so -o %t4.so
+# RUN: ld.lld --version-script %t4.script -shared %t.o %t2.so -o %t4.so --fatal-warnings
 # RUN: llvm-readobj --dyn-syms %t4.so | FileCheck --check-prefix=VERDSO %s
 
 # RUN: echo "VERSION_1.0 { global: foo1; local: *; };" > %t5.script




More information about the llvm-commits mailing list