[PATCH] D65394: [yaml2obj] - Allow overriding sh_entsize for SHT_GNU_versym sections.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 3 18:37:49 PDT 2019


MaskRay added inline comments.


================
Comment at: test/Object/invalid.test:610
+
+## Check that we report an error if SHT_GNU_versym has invalid
+## sh_entsize value (3 instead of 2) when trying to access the entries.
----------------
How about moving this yaml document to test/tools/yaml2obj/versym-section.yaml?


================
Comment at: tools/yaml2obj/yaml2elf.cpp:800
+  if (Section.EntSize)
+    SHeader.sh_entsize = *Section.EntSize;
+  else
----------------
`?:` may be used here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65394/new/

https://reviews.llvm.org/D65394





More information about the llvm-commits mailing list