[PATCH] D65446: [yaml2obj/obj2yaml] - Add a basic support for extended section indexes.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 3 18:31:11 PDT 2019


MaskRay added inline comments.


================
Comment at: test/tools/obj2yaml/elf-sht-symtab-shndx.yaml:115
+    Type: SHT_PROGBITS
+  - Name:    .symtab_shndxr
+    Type:    SHT_SYMTAB_SHNDX
----------------
The canonical name is `.symtab_shndx`


================
Comment at: test/tools/obj2yaml/elf-sht-symtab-shndx.yaml:139
+Sections:
+  - Name:    .symtab_shndxr1
+    Type:    SHT_SYMTAB_SHNDX
----------------
`.symtab_shndx1`


================
Comment at: test/tools/obj2yaml/elf-sht-symtab-shndx.yaml:144
+    Link:    .symtab
+  - Name:    .symtab_shndxr2
+    Type:    SHT_SYMTAB_SHNDX
----------------
`.symtab_shndx2`


================
Comment at: test/tools/obj2yaml/elf-sht-symtab-shndx.yaml:165
+Sections:
+  - Name:    .symtab_shndxr
+    Type:    SHT_SYMTAB_SHNDX
----------------
``.symtab_shndx`


================
Comment at: test/tools/obj2yaml/elf-sht-symtab-shndx.yaml:188
+Sections:
+  - Name:    .symtab_shndxr
+    Type:    SHT_SYMTAB_SHNDX
----------------
`.symtab_shndx`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65446/new/

https://reviews.llvm.org/D65446





More information about the llvm-commits mailing list