[PATCH] D65680: [yaml2obj][tests] Fix overly restrictive od output check

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 3 08:11:21 PDT 2019


MaskRay added a comment.

In D65680#1613485 <https://reviews.llvm.org/D65680#1613485>, @hubert.reinterpretcast wrote:

> In D65680#1613409 <https://reviews.llvm.org/D65680#1613409>, @grimar wrote:
>
> > > rL364517 <https://reviews.llvm.org/rL364517> introduced further instances of od output checking of the kind previously corrected by rL363829 <https://reviews.llvm.org/rL363829>.
> >
> > I leaved a comment for rL363829 <https://reviews.llvm.org/rL363829>, it seems broke at least one of the tests.
>
>
> I've answered the question asked in rL363829 <https://reviews.llvm.org/rL363829>.


We want to see the raw output... It is more descriptive than words I think.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65680/new/

https://reviews.llvm.org/D65680





More information about the llvm-commits mailing list