[PATCH] D65253: [sanitizer_common] Replace forkpty with posix_spawn on Darwin

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 2 12:24:08 PDT 2019


vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_mac.cc:53
   explicit AtosSymbolizerProcess(const char *path, pid_t parent_pid)
-      : SymbolizerProcess(path, /*use_forkpty*/ true) {
+      : SymbolizerProcess(path, /*use_posix_spawn*/ true) {
     // Put the string command line argument in the object so that it outlives
----------------
Do we have use_posix_spawn = false on mac anywhere?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65253/new/

https://reviews.llvm.org/D65253





More information about the llvm-commits mailing list